-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(package): add ClonedFrom
field to PackageMetadata
#527
Conversation
We recently exposed the source repo for e.g. Compute Starter Kits via the `cloned_from` key in the PackageMetadata resource in the API. This makes it programmatically accessible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments, otherwise LGTM.
* Sort struct fields * Run `make fix-fixtures FASTLY_TEST_SERVICE_ID=sSsCewrlNQiMzZHiqD8Xr0`
This updates the valid.tar.gz package to the current Rust empty Starter Kit and updates fixtures to match by following the steps in TESTING.md.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated this from the newest Rust empty Starter Kit, so it got a little smaller (yay) and added the cloned_from
metadata
ClonedFrom
field to PackageMetadata
We recently exposed the source repo for e.g. Compute Starter Kits via
the
cloned_from
key in the PackageMetadata resource in the API. Thismakes it programmatically accessible.